Skip to content

Upgrade dotenv and dotenv-expand to latest version#7119

Closed
ericrallen wants to merge 1 commit into
react:masterfrom
ericrallen:feature/upgrade-dotenv-and-dotenv-expand
Closed

Upgrade dotenv and dotenv-expand to latest version#7119
ericrallen wants to merge 1 commit into
react:masterfrom
ericrallen:feature/upgrade-dotenv-and-dotenv-expand

Conversation

@ericrallen

Copy link
Copy Markdown

The 5.*.* release of dotenv-expand fixes a bug where ENV variables set in the CLI as empty were getting overwritten by values in .env files, this bug was previously fixed in dotenv, but the fix was not ported over to dotenv-expand until recently.

It also adds better support for ENV variable values with $s in them and better handling of escaped $s in values.

I went ahead and updated dotenv to the latest version, as well. I believe the major version bump was just to drop support for older versions of Node.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@ericrallen ericrallen changed the title Upgrade dotenv and dot-env expand to latest version Upgrade dotenv and dotenv-expand to latest version May 27, 2019
@ericrallen ericrallen force-pushed the feature/upgrade-dotenv-and-dotenv-expand branch from 1e95a1e to a27b63b Compare May 27, 2019 15:57
@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu

iansu commented May 27, 2019

Copy link
Copy Markdown
Contributor

It's not really clear what the breaking changes are in dotenv-expand between version 4 and 5. @motdotla can you provide any details?

@iansu iansu self-assigned this May 27, 2019
@ericrallen

Copy link
Copy Markdown
Author

@iansu I believe the 4.2.0 -> 5.0.0 bump was the fix that prevented overwriting falsey values passed via the command line.

The 5.0.0 -> 5.1.0 bump was the better handling of ENV values with $s in them.

@ianschmitz ianschmitz closed this May 31, 2019
@ianschmitz ianschmitz reopened this May 31, 2019
@bugzpodder bugzpodder added this to the 3.x milestone Aug 11, 2019
@ianschmitz

Copy link
Copy Markdown
Contributor

Looks like this was already done in another PR. Thanks :)

@ianschmitz ianschmitz closed this Jan 21, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants