Skip to content

Added CI Instructions for AWS Codebuild#7062

Closed
raybooysen wants to merge 2 commits into
react:masterfrom
raybooysen:patch-1
Closed

Added CI Instructions for AWS Codebuild#7062
raybooysen wants to merge 2 commits into
react:masterfrom
raybooysen:patch-1

Conversation

@raybooysen

Copy link
Copy Markdown

No description provided.

@raybooysen raybooysen requested review from amyrlam and iansu as code owners May 16, 2019 06:09
@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Comment thread docusaurus/docs/running-tests.md Outdated
commands:
- echo Entered the install phase...
- npm install
pre_build:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can leave this phase out if it's not doing anything.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread docusaurus/docs/running-tests.md Outdated
phases:
install:
commands:
- echo Entered the install phase...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably isn't necessary to print this comment.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread docusaurus/docs/running-tests.md Outdated
```

1. Trigger your first build with a git push.
1. [Customize your AWS CodeBuild](https://docs.aws.amazon.com/codebuild/latest/userguide/build-spec-ref.html) if needed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean "Customize your buildspec"?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@iansu iansu self-assigned this May 16, 2019
@ianschmitz ianschmitz added this to the 3.x milestone Jan 31, 2020
@amyrlam amyrlam removed their request for review August 24, 2020 05:36
@facebook-github-bot facebook-github-bot deleted the branch react:master July 7, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants