Skip to content

Change CRA version in react-scripts eject warning.#6845

Merged
iansu merged 2 commits into
masterfrom
unknown repository
Apr 19, 2019
Merged

Change CRA version in react-scripts eject warning.#6845
iansu merged 2 commits into
masterfrom
unknown repository

Conversation

@lffg

@lffg lffg commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

Fixes #6838.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu

iansu commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

I think we probably want to say something like Create React App 2+ or Create React App 2 and above.

@iansu iansu self-assigned this Apr 18, 2019
@iansu iansu added this to the 3.0 milestone Apr 18, 2019
@lffg

lffg commented Apr 18, 2019

Copy link
Copy Markdown
Contributor Author

Fixed, @iansu.

@iansu iansu merged commit 022b984 into react:master Apr 19, 2019
@iansu

iansu commented Apr 19, 2019

Copy link
Copy Markdown
Contributor

Thanks!

@lffg lffg deleted the patch-1 branch April 19, 2019 03:48
@lock lock Bot locked and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRA@3: Eject warning message references CRA2

3 participants