Skip to content

Add netbeans to the list#6763

Closed
ferrybig wants to merge 1 commit into
react:masterfrom
ferrybig:patch-1
Closed

Add netbeans to the list#6763
ferrybig wants to merge 1 commit into
react:masterfrom
ferrybig:patch-1

Conversation

@ferrybig

@ferrybig ferrybig commented Apr 5, 2019

Copy link
Copy Markdown

According to the documentation, you can specify a line number using file:number syntax: http://wiki.netbeans.org/FaqCliOpen

netbeans Something.java:55

According to the instructions at https://facebook.github.io/create-react-app/docs/advanced-configuration I need to list my editor at this list detect it, no further testing instructions have been provided

EDIT: At the moment, the Netbeans editor works when placing a shortcut inside /usr/local/bin to Netbeans, and then starting the devserver using REACT_EDITOR=netbeans npm run serve, but I cant find any documentation on how to make a test version of this package so I can actually test the integration

According to the documentation, you can specify a line number using file:number syntax: http://wiki.netbeans.org/FaqCliOpen

> `netbeans Something.java:55`
@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@iansu iansu self-assigned this Apr 5, 2019
@bugzpodder

Copy link
Copy Markdown

@ferrybig you can just edit this file in your node_modules folder and test it this way. Just make sure you find the right one:
either <project_dir>/node_modules/react-scripts/node_modules/react-dev-utils/launch_editor.js or
<project_dir>/node_modules/react-dev-utils/launch_editor.js

@ferrybig

ferrybig commented Apr 9, 2019

Copy link
Copy Markdown
Author

@bugzpodder I was able to fully test my change, and it worked. When clicking the error message in react, netbeans 11 opened the file on the line specified

Example of this working on Netbeans 11 on Ubuntu:

Screenshot from 2019-04-09 15-22-20

Note that I find this change to the project a trivial change, its just copy and pasting some line after basically following some instructions. And thus no copyright can fall on the change itself, and thus no copyright have to be exchanged

@ianschmitz ianschmitz closed this Aug 7, 2019
@ianschmitz ianschmitz reopened this Aug 7, 2019
@ianschmitz

Copy link
Copy Markdown
Contributor

Note that I find this change to the project a trivial change, its just copy and pasting some line after basically following some instructions. And thus no copyright can fall on the change itself, and thus no copyright have to be exchanged

Thanks for the PR. Do you mind signing the CLA (it's very quick and easy). If not, I understand where you're coming from but we require our contributors to complete the CLA before merging any PR. If this doesn't work for you do you mind closing the PR? Thanks!

@bugzpodder bugzpodder added this to the 3.2 milestone Aug 11, 2019
@iansu

iansu commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

Since the author has not signed the CLA I'm going to close this PR. 😞

@iansu iansu closed this Oct 23, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants