Skip to content

add support for Jest's moduleNameMapper configuration#6633

Closed
nareshbhatia wants to merge 2 commits into
react:masterfrom
nareshbhatia:master
Closed

add support for Jest's moduleNameMapper configuration#6633
nareshbhatia wants to merge 2 commits into
react:masterfrom
nareshbhatia:master

Conversation

@nareshbhatia

Copy link
Copy Markdown

Allow merging of external moduleNameMapper configuration with the internal configuration required by react-scripts.

Fixes #4262

Allow merging of external `moduleNameMapper` configuration with the internal configuration required by react-scripts.
@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu iansu self-assigned this Mar 14, 2019
@nareshbhatia

Copy link
Copy Markdown
Author

@iansu, just curious, what are the next steps to approving and merging this PR?

@nareshbhatia

Copy link
Copy Markdown
Author

Requesting an update on this PR. This is the only critical issue that is preventing my company to move from create-react-app-ts to CRA.

TIA

@cubabit

cubabit commented Apr 18, 2019

Copy link
Copy Markdown

Looking forward to this getting merged and released!

@mrmckeb

mrmckeb commented Apr 19, 2019

Copy link
Copy Markdown
Contributor

@nareshbhatia I'm discussing this with @iansu - we have been hard at work at 3.0, and then I think we can take a look at this for you.

@nareshbhatia

Copy link
Copy Markdown
Author

Thanks for the update, @mrmckeb. Waiting eagerly :-)

@ponciusz

ponciusz commented May 6, 2019

Copy link
Copy Markdown

any progress with that??

@bugzpodder bugzpodder added this to the 3.x milestone Aug 11, 2019
@nareshbhatia

nareshbhatia commented Aug 27, 2019

Copy link
Copy Markdown
Author

As far as I can tell, this change has been implemented in code. If yes, this PR can be closed.

Note that the docs are still out-of-sync, moduleNameMapper is not included as a supported tag.

@ianschmitz

Copy link
Copy Markdown
Contributor

Already fixed by #6055.

@ianschmitz ianschmitz closed this Oct 3, 2019
@lock lock Bot locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mocking scoped package libraries

8 participants