Update node version check#5482
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
bugzpodder
left a comment
There was a problem hiding this comment.
I think eslint 5 requires 8.10 or something?
|
Curious if we want to update the package.json engines.node field with this restraint and reference that in this file when doing the check? |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This sounds like a great way to do it. |
adica
left a comment
There was a problem hiding this comment.
please change also Please update to Node 6 or higher for a better, fully supported experience to Please update to Node 9 or higher...
|
Looks like this was already changed. Thanks! |
#5430