Skip to content

Order lint warnings by most recently edited file (#2378) #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kombucha wants to merge 2 commits into from
Closed

Order lint warnings by most recently edited file (#2378) #2409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a82ca60
Order lint warnings by most recently edited file (#2378)
kombucha May 29, 2017
8c9939a
Use webpack stats if possible when sorting warnings
kombucha Jun 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/react-dev-utils/WebpackDevServerUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,24 @@ function createCompiler(webpack, config, appName, urls, useYarn) {

let isFirstCompile = true;

compiler.plugin('after-compile', (compilation, callback) => {
// Order compilation warnings by most recently modified
compilation.warnings = [
...compilation.warnings,

@eddiemonge eddiemonge Jun 1, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it sorts in place, is it necessary to clone the array?

].sort((warning1, warning2) => {
const warning1Time = compilation.fileTimestamps[
warning1.module.resource
] || fs.statSync(warning1.module.resource).mtime.getTime();
const warning2Time = compilation.fileTimestamps[
warning2.module.resource
] || fs.statSync(warning2.module.resource).mtime.getTime();

return warning1Time < warning2Time ? 1 : -1;
Comment on lines +146 to +154

@eddiemonge eddiemonge Jun 1, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
].sort((warning1, warning2) => {
const warning1Time = compilation.fileTimestamps[
warning1.module.resource
] || fs.statSync(warning1.module.resource).mtime.getTime();
const warning2Time = compilation.fileTimestamps[
warning2.module.resource
] || fs.statSync(warning2.module.resource).mtime.getTime();
return warning1Time < warning2Time ? 1 : -1;
].sort((...warnings) => {
const [a, b] = warnings.map(({ module: { resource } }) => (
compilation.fileTimestamps[resource] || fs.statSync(resource).mtime.getTime()
));
return a === b ? 0 : a < b ? 1 : -1;

});

callback();
});

// "done" event fires when Webpack has finished recompiling the bundle.
// Whether or not you have warnings or errors, you will get this event.
compiler.plugin('done', stats => {
Expand Down