Skip to content

Fail when create-react-app is used via a global install (#11473) #11477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukekarrys wants to merge 1 commit into from
Closed

Fail when create-react-app is used via a global install (#11473) #11477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 37 additions & 19 deletions packages/create-react-app/createReactApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ const url = require('url');
const validateProjectName = require('validate-npm-package-name');

const packageJson = require('./package.json');
const pkgUserAgent = process.env.npm_config_user_agent || '';

function isUsingYarn() {
return (process.env.npm_config_user_agent || '').indexOf('yarn') === 0;
return pkgUserAgent.indexOf('yarn') === 0;
}

let projectName;
Expand Down Expand Up @@ -189,6 +190,39 @@ function init() {
process.exit(1);
}

const globalInstallError = message => {
console.log();
console.error(
chalk.yellow(
`${message}\n\n` +
'We no longer support global installation of Create React App.'
)
);
console.log();
console.log(
'Please remove any global installs with one of the following commands:\n' +
'- npm uninstall -g create-react-app\n' +
'- yarn global remove create-react-app'
);
console.log();
console.log(
'The latest instructions for creating a new app can be found here:\n' +
'https://create-react-app.dev/docs/getting-started/'
);
console.log();
};

// We check if there is no package manager user agent set which means that
// the scripts is being run locally instead of via `npx` or `yarn create/dlx`.
//
// It is still possible for `npx` to use to a global or local install of
// create-react-app if one exists, but that case will be caught by the
// version check below.
if (!pkgUserAgent) {
globalInstallError(`You are running \`create-react-app\` globally.`);
process.exit(1);
}

// We first check the registry directly via the API, and if that fails, we try
// the slower `npm view [package] version` command.
//
Expand All @@ -205,25 +239,9 @@ function init() {
})
.then(latest => {
if (latest && semver.lt(packageJson.version, latest)) {
console.log();
console.error(
chalk.yellow(
`You are running \`create-react-app\` ${packageJson.version}, which is behind the latest release (${latest}).\n\n` +
'We no longer support global installation of Create React App.'
)
globalInstallError(
`You are running \`create-react-app\` ${packageJson.version}, which is behind the latest release (${latest}).`
);
console.log();
console.log(
'Please remove any global installs with one of the following commands:\n' +
'- npm uninstall -g create-react-app\n' +
'- yarn global remove create-react-app'
);
console.log();
console.log(
'The latest instructions for creating a new app can be found here:\n' +
'https://create-react-app.dev/docs/getting-started/'
);
console.log();
process.exit(1);
} else {
const useYarn = isUsingYarn();
Expand Down