Skip to content

Update @pmmmwh/react-refresh-webpack-plugin to 0.5.0-rc.3#11316

Merged
raix merged 2 commits into
react:mainfrom
hasanayan:main
Aug 19, 2021
Merged

Update @pmmmwh/react-refresh-webpack-plugin to 0.5.0-rc.3#11316
raix merged 2 commits into
react:mainfrom
hasanayan:main

Conversation

@hasanayan

Copy link
Copy Markdown
Contributor

there were some updates on @pmmmwh/react-refresh-webpack-plugin for webpack 5 and module federation compability. This PR upgrades the dependency to its last version.

Currently react-scripts is using @pmmmwh/react-refresh-webpack-plugin@0.5.0-rc.1, this seems to cause problems with module federation and those problems were fixed in the last version of the plugin. With this PR we aim to upgrade the dependency version to 0.5.0-rc.3 and resolve those issues.

#11241 (comment)

@hasanayan hasanayan changed the title Update package.json Update @pmmmwh/react-refresh-webpack-plugin to 0.5.0-rc.3 Aug 18, 2021
@raix raix added this to the 5.0 milestone Aug 18, 2021
@raix

raix commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

@hasanayan the workbox fix is now on main, tests fail due to the broken workbox package

@raix

raix commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

@hasanayan try merging in main - I think we also need to update the compiled yarn lockfile as a dependency was updated 'yarn compile:lockfile'

@hasanayan

Copy link
Copy Markdown
Contributor Author

@raix yarn.lock files seem to be ignored in this project. I merged main and now everything seem to be fine

@raix raix merged commit 08dc7ab into react:main Aug 19, 2021
@raix

raix commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

Super @hasanayan thanks!

Yeah the yarn.lock files are not checked in but we do generate a yarn.cached.lockfile in the create-react-app package - updated by running 'yarn compile:lockfile' (disclaimer I'm yet to figure out the reason behind it)

@hasanayan

Copy link
Copy Markdown
Contributor Author

@raix here is the output I am getting from yarn compile:lockfile :( couldn't figure out the problem

yarn compile:lockfile
yarn run v1.22.11
$ node tasks/compile-lockfile.js
child_process.js:800
throw err;
^

<ref *1> Error: spawnSync yarn ENOENT
at Object.spawnSync (internal/child_process.js:1074:20)
at spawnSync (child_process.js:746:24)
at Object.execFileSync (child_process.js:792:15)
at Object. (C:\Users\esra6\hasan\create-react-app\tasks\compile-lockfile.js:33:12)
at Module._compile (internal/modules/cjs/loader.js:1072:14)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1101:10)
at Module.load (internal/modules/cjs/loader.js:937:32)
at Function.Module._load (internal/modules/cjs/loader.js:778:12)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
at internal/main/run_main_module.js:17:47 {
errno: -4058,
code: 'ENOENT',
syscall: 'spawnSync yarn',
path: 'yarn',
spawnargs: [
'add',
'@babel/core@7.14.2',
'@pmmmwh/react-refresh-webpack-plugin@0.5.0-rc.3',
'@svgr/webpack@5.5.0',
'babel-jest@^26.6.0',
'babel-loader@8.2.2',
'babel-plugin-named-asset-import@^0.3.7',
'babel-preset-react-app@^10.0.0',
'bfj@^7.0.2',
'browserslist@^4.16.6',
'camelcase@^6.2.0',
'case-sensitive-paths-webpack-plugin@2.4.0',
'css-loader@6.2.0',
'css-minimizer-webpack-plugin@3.0.2',
'dotenv@9.0.2',
'dotenv-expand@5.1.0',
'eslint@^7.30.0',
'eslint-config-react-app@^6.0.0',
'eslint-webpack-plugin@^2.5.4',
'file-loader@^6.2.0',
'fs-extra@^10.0.0',
'html-webpack-plugin@5.3.2',
'identity-obj-proxy@3.0.0',
'jest@26.6.0',
'jest-circus@26.6.0',
'jest-resolve@26.6.0',
'jest-watch-typeahead@0.6.1',
'mini-css-extract-plugin@2.1.0',
'postcss@8.3.5',
'postcss-flexbugs-fixes@5.0.2',
'postcss-loader@6.1.1',
'postcss-normalize@10.0.0',
'postcss-preset-env@6.7.0',
'prompts@2.4.1',
'react-app-polyfill@^2.0.0',
'react-dev-utils@^11.0.4',
'react-refresh@^0.10.0',
'resolve@1.20.0',
'resolve-url-loader@^4.0.0',
'sass-loader@^12.1.0',
'semver@7.3.5',
'source-map-loader@^1.1.2',
'style-loader@3.0.0',
'webpack@5.41.1',
'webpack-dev-server@4.0.0',
'webpack-manifest-plugin@3.1.1',
'workbox-webpack-plugin@6.2.4'
],
error: [Circular *1],
status: null,
signal: null,
output: null,
pid: 0,
stdout: null,
stderr: null
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@raix

raix commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

@hasanayan what version of node are you on?

@hasanayan

Copy link
Copy Markdown
Contributor Author

@raix 14.17.5

@raix

raix commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

@hasanayan can't replicate 14.17.5 works fine for me

It's running the yarn add ... command so it seems like it's yarn exiting - what version of yarn are you on? Edit: (I'm on 1.22.5)
(could try yarn cache clean)

@hasanayan

Copy link
Copy Markdown
Contributor Author

@raix my yarn version was 1.22.11 but I also tried your now and the result is the same. Anyway, I don't wanna bother you with this anymore. I am on my sister's laptop now and I hope my own machine will not have the same problem. Thanks for the support! 👊

@raix

raix commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

@hasanayan no worries - thanks again! :)

@hasanayan

Copy link
Copy Markdown
Contributor Author

@hasanayan you are welcome. I am a CRA contributor now YAY!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants