feat: add Tagalog (tl_PH) locale for pagination#688
Conversation
|
Someone is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
概览新增 变更菲律宾语 Locale
相关 PR
预期代码审查工作量🎯 1 (简单) | ⏱️ ~3 分钟 诗
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/locale/tl_PH.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-react". (The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs+fabric@4.0.1_postcss@8.5.14/node_modules/@umijs/fabric/dist/eslint.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a new Filipino (Philippines) localization file for the pagination component. The review feedback suggests improving grammatical correctness by adding linkers to numeric phrases, using a more idiomatic term for 'Page Size', and adding a trailing newline for file consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Review: Compatibility issue between
|
| Project | Filipino locale name |
|---|---|
| This PR (rc-pagination) | fil_PH |
| dayjs | tl-ph (tl_PH) |
The two use different ISO codes: fil (ISO 639-1) vs tl (ISO 639-2/T, Tagalog). In practice, Filipino is based on Tagalog and they refer to the same language.
Suggested approaches
- Use
tl_PHinstead — aligns with dayjstl-ph, enabling direct integration with antd - Open a PR on dayjs upstream first to add a
fillocale, then proceed with this PR - Keep
fil_PHas-is — iffilis considered the more standard code, merge this PR first and handle the dayjs mapping separately in antd
I would suggest clarifying the direction before merging to avoid naming inconsistencies during antd integration.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #688 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 3 3
Lines 312 312
Branches 140 140
=======================================
Hits 309 309
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add Filipino (Tagalog) translation for pagination components. - Use tl_PH instead of fil_PH to align with the ecosystem standards, ensuring compatibility with dayjs (tl-ph) and antd integration.
Summary by CodeRabbit
发布说明