Skip to content

fix(toolbar): align slotted toolbar content - #43

Open
rdlabo wants to merge 2 commits into
mainfrom
fix/toolbar-slot-spacing
Open

fix(toolbar): align slotted toolbar content#43
rdlabo wants to merge 2 commits into
mainfrom
fix/toolbar-slot-spacing

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • scope toolbar spacing styles directly to enabled Material toolbars
  • preserve title padding based on the presence of a start slot
  • use the Ionic-provided toolbar-searchbar state and toolbar padding variables for sides without slot content

Verification

  • npm run lint
  • npm run build

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

failed  10 failed
passed  68 passed

Details

stats  78 tests across 1 suite
duration  2 minutes, 36 seconds
commit  56d9792
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

Failed tests

chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for button
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for segment
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for popover
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for searchbar
chromium › screenshot.spec.ts › Screenshot Tests - All Routes › should match screenshot for toolbar
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for button
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for segment
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for popover
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for searchbar
chromium › screenshot.spec.ts › Screenshot Tests - Dark Mode › should match dark mode screenshot for toolbar

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-43/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 2, 2026
@rdlabo
rdlabo force-pushed the fix/toolbar-slot-spacing branch from 439083c to 56d9792 Compare September 2, 2026 08:01
github-actions Bot added a commit that referenced this pull request Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-43/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

@rdlabo

rdlabo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/update-screenshots

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

✅ Screenshots have been updated successfully!

The new screenshots have been committed to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant