Skip to content

fix(list): respect ion-note color in inset lists #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdlabo merged 2 commits into from
Sep 1, 2026
Merged

fix(list): respect ion-note color in inset lists #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a39f1fc
fix(list): respect ion-note color in inset lists
rdlabo Sep 1, 2026
fddc650
chore: update E2E screenshots
github-actions[bot] Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified demo/e2e/screenshot.spec.ts-snapshots/item-list-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified demo/e2e/screenshot.spec.ts-snapshots/item-list.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions demo/src/app/index/pages/item-list/item-list.page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ <h2>item-list</h2>
</ion-item>
</ion-item-group>
<ion-note>Note additional information.</ion-note>
<ion-note color="primary">Primary note additional information.</ion-note>
<ion-note color="danger">Danger note additional information.</ion-note>
</ion-list>

<ion-list [inset]="true">
Expand Down
2 changes: 1 addition & 1 deletion src/styles/utils/structured-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ $groups: ion-item-group, ion-reorder-group, ion-accordion-group, ion-radio-group
}

& > ion-note {
color: var(--ion-color-medium-tint);
--color: var(--ion-color-medium-tint);
font-size: 0.9rem;
display: block;
margin: 8px calc(var(--ion-safe-area-right, 0) + $outer-note-inset) 8px calc(var(--ion-safe-area-left, 0) + $outer-note-inset);
Expand Down
Loading