Skip to content

refactor: prefer CSS custom properties over Shadow Parts - #39

Merged
rdlabo merged 2 commits into
mainfrom
refactor/prefer-css-custom-properties
Aug 31, 2026
Merged

refactor: prefer CSS custom properties over Shadow Parts#39
rdlabo merged 2 commits into
mainfrom
refactor/prefer-css-custom-properties

Conversation

@rdlabo

@rdlabo rdlabo commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move eligible back-button, range, toggle, item, and detail-icon styling to documented Ionic CSS custom properties
  • keep Shadow Parts only for dimensions, transforms, and borders without an equivalent public variable
  • preserve existing component appearance, color-state behavior, RTL behavior, and user override paths

Compatibility review

  • no demo-specific IDs, routes, fixtures, or DOM ordering assumptions
  • selectors cover Ionic color and checked combinations
  • user overrides remain possible through ordinary later CSS custom-property declarations
  • manager review and independent acceptance review completed with no blocking findings

Validation

  • npm run build
  • npm run lint
  • git diff --check
  • 10 affected Mac Chrome light/dark screenshots matched the before-change baseline

Linux Playwright snapshots were not modified.

Important-declaration cleanup is intentionally split into a separate stacked PR.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  78 passed

Details

stats  78 tests across 1 suite
duration  1 minute, 36 seconds
commit  a64b120
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-39/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@rdlabo
rdlabo force-pushed the refactor/prefer-css-custom-properties branch from a78cbf9 to 7bf72f6 Compare August 31, 2026 03:48
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-39/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@rdlabo
rdlabo merged commit 337938e into main Aug 31, 2026
9 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-md3/pr-39/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant