fix(offline): keep snapshot reads in atomic owner - #95
Merged
Conversation
npm beta packages publishedCI passed for the merge commit npm install @rdlabo/ionic-angular-kit@22.0.0-beta.pr95.shac320513779dc @rdlabo/ionic-angular-photo-editor@22.0.0-beta.pr95.shac320513779dc @rdlabo/ionic-angular-scroll-header@22.0.0-beta.pr95.shac320513779dc @rdlabo/ngx-cdk-scroll-strategies@22.0.0-beta.pr95.shac320513779dc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Fixes the production error
Use the repository passed to an atomic mutation for snapshot reads.observed in winecode on/main/list. The SQLite safety guard remains intact; callers now use the correct atomic owner instead of re-entering the root repository.Verification
npx ng test kit --watch=false(985 tests)npx ng test kit --watch=false --include ../offline/src/lib/offline-sync.service.spec.ts(175 tests)npm run lintnpm run prebuild:kit