perf(kit): use granular Ionic controller imports - #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ionic/angularroot barrel with the public controller entrypointsNavControllerfrom@ionic/angular/commonWhy
The root barrel makes consuming applications retain the Ionic standalone component graph even when the kit only needs overlay controllers. In the SeatKeep production graph, this change removes the standalone root index from the initial static closure.
Measured impact
Verification
npm run lintnpm test(74 files, 1,075 tests)npm run prebuildfrom '@ionic/angular'importNo migration notes are needed because this is an internal import-boundary change with no public API or behavior change. The package version is intentionally unchanged and will be managed during release.