fix: expose CodeTypes on ScannerOption to match native - #19
Merged
Conversation
Keep the published API reference in sync with src/definitions.ts.
Native iOS and Android already read CodeTypes. Align the TypeScript interface, document detection-area defaults, and accept the previous metadataObjectTypes key as a fallback.
rdlabo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScannerOptionfrommetadataObjectTypestoCodeTypes, matching iOS and Android.detectionWidth/detectionHeightand makeisMultioptional (native already defaults tofalse).metadataObjectTypeskey as a native fallback.CodeTypesin the guide examples.Test plan
npm run docgenmatches the committed READMEpresent({ CodeTypes: ['qr'] })type-checksmetadataObjectTypesis passed