COVERITY TEST. DO NOT MERGE#109
Closed
snampo768 wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an intentionally unsafe helper method to FirmwareConfigService to trigger static-analysis findings (per PR title/description: “COVERITY TEST. DO NOT MERGE”).
Changes:
- Introduced a new private helper (
coverityProbe) containing deliberate null-dereference/resource-handling issues for Coverity verification.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Intentionally unsafe helper to verify static-analysis findings in Coverity. | ||
| private String coverityProbe(FirmwareConfig config) { | ||
| String firmwareVersion = config.getFirmwareVersion(); | ||
| if (config == null) { |
| return null; | ||
| } | ||
|
|
||
| if (firmwareVersion == null && firmwareVersion.length() == 0) { |
Author
|
Close Test PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COVERITY TEST. DO NOT MERGE