RDKEMW-18247 Panel is listing as a PLATCO device in Router client list in WiFi mode#313
Open
cmuhammedrafi wants to merge 5 commits into
Open
RDKEMW-18247 Panel is listing as a PLATCO device in Router client list in WiFi mode#313cmuhammedrafi wants to merge 5 commits into
cmuhammedrafi wants to merge 5 commits into
Conversation
…t in WiFi mode Reason for change: Set the NetworkManager dhcp-hostname in the connection profile to use the default hostname instead of the device name.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GNOME NetworkManager plugin to prefer a “default hostname” for DHCP hostname configuration (instead of a device name), aiming to prevent the panel from showing up as a PLATCO device in router client lists while in WiFi mode.
Changes:
- Only set
dhcp-hostname/dhcp-send-hostnamein newly created WiFi/Ethernet connection profiles when the resolved hostname is non-empty. - Update device properties parsing to read
DEFAULT_HOSTNAME(and update CI workflow fixture accordingly). - Add a guard in the proxy path to avoid modifying existing NM connection profiles when the resolved default hostname is empty.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugin/gnome/NetworkManagerGnomeWIFI.cpp | Conditionally applies DHCP hostname settings (IPv4/IPv6) only when a non-empty hostname is available; adds logging for empty/non-empty hostname. |
| plugin/gnome/NetworkManagerGnomeUtils.cpp | Switches device properties parsing from DEVICE_NAME to DEFAULT_HOSTNAME. |
| plugin/gnome/NetworkManagerGnomeProxy.cpp | Avoids modifying existing NM connections when no default hostname is available. |
| .github/workflows/libnm_proxy_L1_test.yml | Updates test fixture to provide DEFAULT_HOSTNAME in /etc/device.properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+264
to
265
| if (line.find("DEFAULT_HOSTNAME=") != std::string::npos) { | ||
| deviceHostname = line.substr(line.find('=') + 1); |
Comment on lines
153
to
+157
| hostname = nmUtils::deviceHostname(); // default hostname as device name | ||
| if(hostname.empty()) | ||
| { | ||
| NMLOG_WARNING("default hostname is empty no modification in nm connections"); | ||
| return false; |
bpunnuru
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-18247 Panel is listing as a PLATCO device in Router client list in WiFi mode
Reason for change: Set the NetworkManager dhcp-hostname in the connection profile
to use the default hostname instead of the device name.