V1 10 5#206
Open
rchillyard wants to merge 4 commits into
Open
Conversation
- Fix missing case for exp(-β) β 0 (surfaced by EML tree expansion)
- Fix missing case for UniFunction(Zero, Exp) β One
- Fix infinite loop in Expression.simplify for expressions involving Infinity
- Add BiFunction guard: expressions involving Infinity short-circuit simplification
- Add commutativity flatMap fix in BiFunction.structuralMatcher for correct
re-matching after operand swap
- Add Noop("NaN") results for indeterminate forms: β + (-β), 0 Γ β
- Add ExpressionMatcherPatterns test trait with simplifiesTo helper
- Add Infinity rules test in ExpressionSpec
- Add Noop rules (and test)
- Add override evaluateAsIs in Noop
- Add Noop.apply for standard "NaN"
- Add Number.`β`
- Add ExpressionMatcherPatterns (currently unused)
Bugs surfaced by systematic EML tree expansion (expandN) in NumberApps,
which generated 458,285 distinct expression trees and exposed edge cases
in the simplifier that would have been very difficult to find by hand.
Otherwise, mostly cosmetic changes due to renaming isInfinity to isInfinite.
Number changes:
- Fix exp(-β) β 0 (1.10.3)
- Fix UniFunction(Zero, Exp) β One
- Fix ln(exp(x)) β x simplification
- Fix commutativity flatMap in BiFunction.structuralMatcher
- Add Expression-level guards: β + (-β), 0 Γ β β Noop("NaN")
- Add core-level guards for indeterminate forms involving β
- Fix publishLocal race condition via concurrentRestrictions
- Add ExpressionMatcherPatterns test trait with simplifiesTo helper
- Add Infinity rules tests
Documentation changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.