Add Network discovery metadata - #28
Open
rchatham wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Bonjour discovery identity metadata for the Network transport stack so discovered Network browser results can map to framework-neutral
PeerIdentityvalues and endpoints.Changes
PeerNetworkDiscoveryInfofor TXT record encode/decode.NetworkPeerListener.NWBrowser.ResultBonjour metadata inNetworkPeerBrowserTransport.PeerIdentity -> NWEndpointmappings for laterinvitePeerconnection attempts.Non-goals
Verification
swift test— 88 tests passedxcodebuild test -project PeerConnectivity.xcodeproj -scheme PeerConnectivity -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' -configuration Debug— 88 tests passedStack context
Stacked on PR #27 (
feature/network-migration-transport-adapters). This is the discovery metadata slice in the Network migration stack.