Repository navigation
ci: time out the e2e report step after 5 minutes - #48
Merged
Merged
Conversation
A hung ffmpeg or apt-get in 'Report and demo video' ran the e2e job into its 60-minute cap twice and cancelled a run whose tests had all passed. The step now has its own 5-minute limit and continue-on-error; the feature tests still gate the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A hung report step can no longer cancel a passed e2e job.
Report and demo videonow hastimeout-minutes: 5andcontinue-on-error: true(it already runsif: always()).Why: on #47 this step hung twice (ffmpeg or apt-get) after every test passed, ran the job into its 60-minute cap, and GitHub cancelled the
e2echeck, which blocked the merge until a re-run.Tests
timeout-minutes,continue-on-errorandifchecked.