Repository navigation
fix: Froyo widget reads live list from fold row data - #46
Merged
Merged
Conversation
The gateway's custom fold row for open_items_live is
{data: {items, as_of}, at, writer, stale_after}. The widget read
open_items_live.items, found nothing, and fell back to Froyo's
hand-written open_items, which is stale (no snorkel trip). Read
data.items first, the way Froyo's own page does; keep bare items as
a fallback. Adds tests for the real row shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Froyo · Upcoming" widget did not show the Fri 6 Nov house reef snorkel trip even after refresh.
Cause: Froyo's v4 page binds
open_items_liveto the gateway's custom fold row, which is shaped{data: {items, as_of}, at, writer, stale_after}.Upcoming.extractItemsreadopen_items_live.items,got null, and fell back to Froyo's hand-written
open_itemsfield, which is stale and has no snorkel row.Froyo's own page reads
live.data.items, so the page looked right while the widget did not.Fix: read
open_items_live.data.itemsfirst; keep bareitemsas a fallback; thenopen_items.Tested
theLiveListIsReadFromTheFoldRowsDataandaFoldRowWithNoListInItsDataFallsBackToOpenItemsinUpcomingTest.open_itemsevery 15 min (security logdashboard_record allowed), and its list has the snorkel item as row 2. Phone requests to/api/members/froyo-personal-butler/dashboardsucceed on the fixed path (post-fix: drop dashboard page path from server URL (Froyo widget) #45).Not merged: needs review.