Repository navigation
fix: Froyo widget says why a read failed, reads open_items_live - #44
Merged
Merged
Conversation
The header now shows the reason next to 'as of HH:mm' (sign-in, network, timeout, server, format), and logs it under the FroyoWidget tag. Reads prefer Froyo's open_items_live (kept current by its sync job) and fall back to open_items. A 400/404/409 asks for Froyo's thread again once, and the dashboard read waits up to 45 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Froyo widget no longer fails silently. A failed read now says why, and reads prefer Froyo's live list.
N open · Updated HH:mmN open · as of HH:mm · sign-in… · network… · timeout… · server… · formatCouldn't update · <reason>.FroyoWidgetwith the HTTP code or exception (adb logcat -s FroyoWidget).open_items_live.items(Froyo page v4: kept current every 15 min by its sync job) and fall back toopen_items.Checked on the gateway side: auth on
/api/members/froyo-personal-butler/dashboardpasses in its audit log, and the v4 page, rendered with the gateway's own code, carriesopen_itemsandopen_items_livein the data island the widget reads.Tests
UpcomingTest: v4-shaped response prefers the live list; falls back when it is missing, not an object, or has noitems; empty live list is "nothing open"; reason table; stale-thread codes;as of HH:mmcarries the reason.Froyo widget: fake gateway serves the v4 shape with a stale extra row inopen_items(never shown); 503 ->· network; 200 without a list ->· format; rows kept; next good read clears the reason.Not covered