Skip to content

fix: [select] pass searchValue to the autocomplete search input - #968

Open
Shreyag02 wants to merge 1 commit into
fix/combobox-input-valuefrom
fix/select-search-value
Open

Shreyag02 wants to merge 1 commit into
fix/combobox-input-valuefrom
fix/select-search-value

Conversation

@Shreyag02

Copy link
Copy Markdown
Contributor

Summary

  • Pass searchValue and defaultSearchValue to the Base UI Combobox as inputValue and defaultInputValue in autocomplete mode. A controlled searchValue filtered the list while the search input stayed empty, and defaultSearchValue filtered the list while the input was empty.
  • Add tests for the search input with a controlled searchValue and with defaultSearchValue.

Stacked on #966. Retarget to main after it merges.

@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
apsara Ready Ready Preview Oct 11, 2026 7:49pm UTC

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fd551953-843f-46ee-9538-5b7732c81282

📥 Commits

Reviewing files that changed from the base of the PR and between a795a59 and 67ef5ca.


📒 Files selected for processing (2)
  • packages/react/components/select/__tests__/select.test.tsx
  • packages/react/components/select/select-root.tsx

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 11, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@raystack/apsara@968

commit: 67ef5ca

@Shreyag02 Shreyag02 self-assigned this Oct 11, 2026
@Shreyag02
Shreyag02 changed the base branch from refactor/use-controlled to fix/combobox-input-value October 11, 2026 19:48
@Shreyag02
Shreyag02 added this pull request to stack #970 October 11, 2026 19:48

This branch was successfully deployed

1 active deployment
Preview — 67ef5ca5 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant