Repository navigation
fix: [combobox] filter items by inputValue and defaultInputValue - #967
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 17 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly identifies the primary change: Combobox filtering now uses inputValue and defaultInputValue. Description check The description directly explains the Combobox filtering tests and the useControlled-based source fix.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
⚔️ Resolve merge conflicts: 💡
-
- Resolve merge conflict in branch
fix/combobox-input-value
- Resolve merge conflict in branch
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Shreyag02
added this pull request to stack #969
October 11, 2026 19:44
commit: |
Shreyag02
removed this pull request from stack #969
October 11, 2026 19:46
Shreyag02
added this pull request to stack #970
October 11, 2026 19:48
rohanchkrabrty
approved these changes
Oct 15, 2026
1 task done
# Conflicts: # packages/react/components/color-picker/color-picker-root.tsx # packages/react/components/combobox/combobox-root.tsx # packages/react/components/command/command-root.tsx # packages/react/components/select/select-root.tsx
1 task done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add tests for Combobox filtering with a controlled
inputValueand withdefaultInputValue.The source fix shipped in refactor: use base ui useControlled for controlled state #966, which passes both props to
useControlledfor the filter value.I have followed the pull request section of the contributing guide.