Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
commit: |
a0ae559 to
0a1301b
Compare
0a1301b to
9f1b4c9
Compare
9f1b4c9 to
81c8020
Compare
81c8020 to
cfbe726
Compare
Summary
Multi-select
Combobox.Inputrenders chips with Base UICombobox.Chips,Chip, andChipRemove. Chips get thetoolbarrole, arrow keys move between chips, and Backspace removes the last value. The look and the "+N" overflow chip stay the same.Add
Combobox.Label(a visible label linked to the input),Combobox.Clear(clear-all button),Combobox.Empty("No results" live region), andCombobox.Status(hidden live region with the result count).Combobox.Contentrenders Empty and Status by default. Place either one inside Content to change its text.Why it's like this: Combobox was first built on Ariakit (feat: combobox component #565), which has no chips part, so it reused the
chipsprop of our Input. The move to Base UI (feat: migrate Select to Base UI #591) kept that setup.Breaking: chips no longer use the Input
chipsprop. Theinput-chip-container,input-chip, andinput-chip-overflowslots inside a combobox are nowcombobox-chips,combobox-chip,combobox-chip-remove, andcombobox-chip-overflow. The group label part is renamed fromCombobox.LabeltoCombobox.GroupLabel, and its slot fromcombobox-labeltocombobox-group-label.Combobox.Labelandcombobox-labelnow mean the input label.Docs: new parts in props, demos, anatomy, and the Slots table.
I have followed the pull request section of the contributing guide.