Repository navigation
feat: [combobox] add createItems for id-based values #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9eaae4c
feat: [combobox] add createItems for id-based values
ravisuhag 8f4c27c
fix: [combobox] show item labels on multi-select chips
ravisuhag f7f1d1c
refactor: [combobox] use base ui createItems and label chips with ite…
rohanchkrabrty 89f1147
fix: [combobox] label chips in the same order as base ui
rohanchkrabrty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: raystack/apsara
Length of output: 5792
🏁 Script executed:
Repository: raystack/apsara
Length of output: 5492
🌐 Web query:
official Base UI v1.8.0 Combobox createItems ItemCollection Root items type💡 Result:
🌐 Web query:
site:github.com/mui/base-ui/tree/v1.8.0 packages/react/src/combobox itemCollection.ts ComboboxRoot items ItemCollection💡 Result:
🏁 Script executed:
Repository: raystack/apsara
Length of output: 1432
🏁 Script executed:
Repository: raystack/apsara
Length of output: 7800
🏁 Script executed:
Repository: raystack/apsara
Length of output: 6064
🏁 Script executed:
Repository: raystack/apsara
Length of output: 9602
🏁 Script executed:
Repository: raystack/apsara
Length of output: 2448
🏁 Script executed:
Repository: raystack/apsara
Length of output: 4251
Include the
createItemscollection in the documenteditemstype.Combobox.createItemsreturns an opaque collection thatCombobox.Root.itemsaccepts. The declaration currently permits only arrays, so it excludes the documented ID-based usage.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents