feat: [data-view] forward popup position props and Search leadingIcon by rohanchkrabrty · Pull Request #931 · raystack/apsara

rohanchkrabrty · 2026-09-29T15:10:00Z

Summary

DataView.Filters accepts align, side, and sideOffset and passes them to the add-filter Menu.Content. The defaults are unchanged (start, bottom, 4px).
DataView.DisplayControls accepts the same three props and passes them to its Popover.Content. align still defaults to end.
Search accepts leadingIcon. A node replaces the search icon, and null hides it. DataView.Search and DataTable.Search get the prop through SearchProps.
Docs: a DataView.Filters props table, the position props on DataView.DisplayControls, and a "Leading icon" section with a demo on the Search page.

Closes #848

I have followed the pull request section of the contributing guide.

vercel · 2026-09-29T15:10:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
apsara	Ready	Preview	Oct 5, 2026 7:58am UTC

coderabbitai · 2026-09-29T15:10:57Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 89ed48e4-9020-4716-8658-4a74f6885b25

📥 Commits

Reviewing files that changed from the base of the PR and between dffabce and 9078448.

📒 Files selected for processing (11)

apps/www/src/content/docs/components/search/demo.ts
apps/www/src/content/docs/components/search/index.mdx
apps/www/src/content/docs/components/search/props.ts
apps/www/src/content/docs/dataview/index.mdx
apps/www/src/content/docs/dataview/props.ts
packages/raystack/components/data-view/__tests__/data-view.test.tsx
packages/raystack/components/data-view/components/display-controls.tsx
packages/raystack/components/data-view/components/filters.tsx
packages/raystack/components/popover/popover.tsx
packages/raystack/components/search/__tests__/search.test.tsx
packages/raystack/components/search/search.tsx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: ec41e3dc-1cf6-4c55-a0d4-ce9a0e73c5d6

📥 Commits

Reviewing files that changed from the base of the PR and between ae17be6 and dffabce.

📒 Files selected for processing (2)

packages/raystack/components/data-view/components/display-controls.tsx
packages/raystack/components/popover/popover.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

Search now accepts a custom leading icon or null to hide the icon, while retaining the default search icon. DataView.Filters and DataView.DisplayControls now accept popup positioning props and forward them to their underlying menu or popover. Tests and documentation cover these changes.

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant DisplayControls
  participant PopoverContent
  participant Positioner
  Caller->>DisplayControls: Set align, side, and sideOffset
  DisplayControls->>PopoverContent: Forward positioning props
  PopoverContent->>Positioner: Pass sideOffset and remaining props

Suggested reviewers: ravisuhag

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to dffab

This change adds optional positioning props to DataView Filters and DisplayControls and a leadingIcon option to Search, with existing defaults preserved. No merge-blocking risk is evident.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to dffab

The changes expose presentation options through existing UI components. The inspected changes preserve state-update behavior and popup controls, with no material security risk introduced or worsened.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

inferred — The supported exposure is presentation behavior in applications consuming these reusable components. The inspected changes add no service, tenant identity, credential, or data-store authority; deployed consumer reach is not established by this evidence.

Trust Boundaries and Controls

inferred — The examined inputs are application-supplied component props flowing to existing layout and React rendering sinks. No new path from an external identity or request to a privileged operation is demonstrated, and the Popover boundary comparison shows no weakened control.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 9 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main changes: forwarding popup position props and adding Search leadingIcon support.
Description check	✅ Passed	The description explains the new positioning props, Search leadingIcon behavior, and related documentation changes.
Linked Issues check	✅ Passed	Issue `#848` requirements are met. `DataView.Filters` forwards `align`, `side`, and `sideOffset` to `Menu.Content`. `DataView.DisplayControls` forwards these props to `Popover.Content` and retains `alig…
Out of Scope Changes check	✅ Passed	All reviewed changes support issue `#848`. The component changes implement prop forwarding and icon control. The `Popover.Content` change enables configurable `sideOffset` for `DisplayControls`. Tests, …

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-29T15:11:05Z

Open in StackBlitz

pnpm add https://pkg.pr.new/@raystack/apsara@931

commit: 9078448

…-props # Conflicts: # packages/raystack/components/data-view/__tests__/data-view.test.tsx

feat: [data-view] forward popup position props and Search leadingIcon

ae17be6

rohanchkrabrty self-assigned this Sep 29, 2026

rohanchkrabrty requested review from Shreyag02 and rohilsurana September 29, 2026 15:10

vercel Bot deployed to Preview September 29, 2026 15:13 View deployment

Shreyag02 reviewed Sep 30, 2026

View reviewed changes

Comment thread packages/raystack/components/data-view/components/display-controls.tsx Outdated

Comment thread apps/www/src/content/docs/components/search/props.ts

Comment thread apps/www/src/content/docs/components/search/index.mdx

rohanchkrabrty added 2 commits October 5, 2026 01:11

fix: [data-view] keep popup position defaults when props are undefined

7ee7e64

test: [data-view] remove align undefined test

dffabce

rohanchkrabrty requested a review from Shreyag02 October 4, 2026 19:44

vercel Bot deployed to Preview October 4, 2026 19:48 View deployment

Shreyag02 approved these changes Oct 5, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into feat/dataview-control…

9078448

…-props # Conflicts: # packages/raystack/components/data-view/__tests__/data-view.test.tsx

vercel Bot deployed to Preview October 5, 2026 07:58 View deployment

rohanchkrabrty merged commit 1ccf845 into main Oct 5, 2026
8 checks passed

rohanchkrabrty deleted the feat/dataview-control-props branch October 5, 2026 08:26

Navigation Menu

feat: [data-view] forward popup position props and Search leadingIcon - #931

feat: [data-view] forward popup position props and Search leadingIcon#931
rohanchkrabrty merged 4 commits into
mainfrom
feat/dataview-control-props

rohanchkrabrty commented Sep 29, 2026

Uh oh!

vercel Bot commented Sep 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 29, 2026 •

edited

Loading

Review limit reached

Walkthrough

Sequence Diagram(s)

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Sep 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rohanchkrabrty commented Sep 29, 2026

Summary

Uh oh!

vercel Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Sequence Diagram(s)

Security Architecture Review

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented Sep 29, 2026 •

edited

Loading

coderabbitai Bot commented Sep 29, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 29, 2026 •

edited

Loading