fix: [command, data-view] close keyboard and screen reader gaps - #929
Merged
Merged
Conversation
Command.Item passes disabled to the Base UI item, so arrow keys reach disabled items and Enter does not activate them. DataView.Toolbar announces the result count in a role="status" region while a search or filter is active. The add-filter and sort direction icon buttons have accessible names.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 13 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Shreyag02
reviewed
Sep 30, 2026
Server mode has no count of matching results, and a count that changes on every keystroke makes screen readers announce once per key. The toolbar status now reads the footer text, debounced by 500ms.
The status region is a span inside FilterSummary, so List and Timeline announce the footer text. The span stays rendered when the footer is hidden, because a live region announces only text that changes after it mounts.
"Sort ascending" read as an action, but pressing it sorts descending.
Shreyag02
approved these changes
Oct 5, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Command.Itempassesdisabledto the Base UI item instead of rendering a rawdiv. Arrow keys reach disabled items, andEnterdoes not activate them.role="status"span (data-view-filter-summary-status). List, Timeline andDataView.ClearFilters(empty state) render it. It announces the footer text, for example "3 items hidden by filters", once the search and filters stop changing for 500ms. The span stays rendered when the footer is hidden, so later changes are announced.:focus-visiblerules: neither styles a keyboard-focusable element, and the Dialog close button gets its ring fromIconButton.Closes #878