chore: remove stale contracts CI workflow#17
Conversation
rayls-contracts/.github/workflows/test.yml is a leftover from when rayls-contracts was its own repository (came in with the initial port). GitHub Actions only runs workflows from the repo-root .github/workflows, so a nested one never executes — it has been inert since the port. It's also redundant: its forge fmt/build/test steps are already covered by the contracts-tests job in the root pr.yaml, which runs on any rayls-contracts/** change. It further references a POLYGON_RPC_URL secret that doesn't exist here and uses unpinned @v4/@v1 actions.
|
Claude finished @bdimitrov-netzine's task in 1m 19s —— View job PR Review
Verdict: Approve this change. The deletion is safe and the PR description is accurate. Here's a detailed breakdown: Why this is safeThe file was never running. GitHub Actions only picks up workflow files from the repository-root The root
Minor observation (not a blocker)The PR description says the root
This is worth noting for anyone who wants format enforcement: adding Code quality notes on the deleted file (informational)
All of these are moot once the file is deleted, but they underscore that the root workflow is the more mature implementation. Summary: This is a straightforward dead-code removal. The file has been inert since the contracts directory was imported, the root workflow provides proper coverage, and no currently-running CI steps are affected. |
Security Scan - CodeSeverity: HIGH, CRITICAL No vulnerabilities found View scan results |
1 similar comment
Security Scan - CodeSeverity: HIGH, CRITICAL No vulnerabilities found View scan results |
Contracts Tests (Foundry)Package: ✅ All tests passed View forge test results |
What
Deletes
rayls-contracts/.github/workflows/test.yml(and the now-empty nested.github/).Why it's safe
.github/workflows/. This one is nested underrayls-contracts/, so it's been completely inert sincerayls-contractswas ported in from its own repo.forge fmt --check/build/test) are already covered by thecontracts-testsjob in the rootpr.yaml, which runs on anyrayls-contracts/**change.POLYGON_RPC_URLsecret not present in this repo, and uses unpinned@v4/@v1actions.No behavior change — nothing that currently runs is affected.