[core] fix test_streaming_generator_backpressure on windows#64359
[core] fix test_streaming_generator_backpressure on windows#64359rueian wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds Windows-specific error handling when executing driver scripts in streaming generator backpressure tests, catching and logging subprocess.CalledProcessError on Windows while re-raising it on other platforms. The reviewer suggests refactoring this repetitive try-except block into a helper function _run_string_as_driver to reduce code duplication and improve maintainability across the multiple test cases.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3108a06 to
cfcadc9
Compare
Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
cfcadc9 to
a26739b
Compare
Description
Related issues
Additional information