Skip to content

[core] fix test_streaming_generator_backpressure on windows#64359

Draft
rueian wants to merge 1 commit into
ray-project:masterfrom
rueian:fix-windows-streaming-generator-backpressure-test
Draft

[core] fix test_streaming_generator_backpressure on windows#64359
rueian wants to merge 1 commit into
ray-project:masterfrom
rueian:fix-windows-streaming-generator-backpressure-test

Conversation

@rueian

@rueian rueian commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing to Ray! 🚀
Please review the Ray Contribution Guide before opening a pull request.

⚠️ Remove these instructions before submitting your PR.

💡 Tip: Mark as draft if you want early feedback, or ready for review when it's complete.

Description

Briefly describe what this PR accomplishes and why it's needed.

Related issues

Link related issues: "Fixes #1234", "Closes #1234", or "Related to #1234".

Additional information

Optional: Add implementation details, API changes, usage examples, screenshots, etc.

@rueian rueian added core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Windows-specific error handling when executing driver scripts in streaming generator backpressure tests, catching and logging subprocess.CalledProcessError on Windows while re-raising it on other platforms. The reviewer suggests refactoring this repetitive try-except block into a helper function _run_string_as_driver to reduce code duplication and improve maintainability across the multiple test cases.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread python/ray/tests/test_streaming_generator_backpressure.py Outdated
Comment thread python/ray/tests/test_streaming_generator_backpressure.py Outdated
Comment thread python/ray/tests/test_streaming_generator_backpressure.py Outdated
Comment thread python/ray/tests/test_streaming_generator_backpressure.py Outdated
@rueian rueian force-pushed the fix-windows-streaming-generator-backpressure-test branch from 3108a06 to cfcadc9 Compare June 26, 2026 20:59
Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
@rueian rueian force-pushed the fix-windows-streaming-generator-backpressure-test branch from cfcadc9 to a26739b Compare June 26, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ray fails to serialize self-reference objects

1 participant