Skip to content

Split the oversized module Inputs section into its own input-types page - #69

Merged
flybayer merged 1 commit into
mainfrom
devin/1787780059-split-module-inputs-schema-pages
Aug 26, 2026
Merged

Split the oversized module Inputs section into its own input-types page#69
flybayer merged 1 commit into
mainfrom
devin/1787780059-split-module-inputs-schema-pages

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

The nightly Sync schema reference docs job in flightcontrol has failed every run since Aug 15, so nothing generated from TypeSpec has reached these docs for ~3 weeks (most visibly, cancel-intermediate is missing from the published ConcurrencyConfig reference even though it shipped in flightcontrol#6907). The job dies in scripts/sync-schema-reference.mjs:

Error: Section "Inputs" has 221 fields but no grouping rules; add an entry to sectionGroups.

The module Inputs section crossed maxFieldsPerPage (220) by exactly one field, and splitSection throws when an oversized section has no sectionGroups entry. That throw aborts the whole script, so every page — including the unrelated pipeline reference — stops syncing.

Grouping follows the existing Deploy precedent (catch-all group first, so the section intro stays on the lead page):

Inputs: [
  {title: "Inputs"},                                 // 24 fields: values, conditions, refs, validation
  {title: "Input types", match: /InputProperty$/},    // 197 fields: *InputProperty + RefFallback*
],

That keeps the existing inputs slug (and its pageMetadata/OG image) intact and adds one new input-types page, with pageMetadata for it and a narrowed inputs description now that the type reference moved off that page.

The generated content in this PR is the full ~3 weeks of catch-up, regenerated from flightcontrol main at 0d2a8f2a9f (i.e. after the #7044 revert, so it does not contain the reverted build-step concurrency default). Largest visible change is cancel-intermediate and the expanded queue_size semantics landing in the pipeline and module stack references.

Testing

node scripts/sync-schema-reference.mjs + node scripts/sync-og-images.mjs run clean; resulting pages are 197 and 24 fields, both under the 220 budget, and no other page moved past it. pnpm validate passes.

Link to Devin session: https://app.devin.ai/sessions/473f180911ca4629901d5d61fa043fd6
Requested by: @flybayer

Greptile Summary

The PR splits the oversized module Inputs schema reference into separate Inputs and Input types pages, then refreshes generated schema content accumulated during the failed synchronization period.

  • Adds the new page, metadata, navigation entry, and generated index link.
  • Moves *InputProperty definitions and updates generated cross-page references.
  • Refreshes module, pipeline, and project schema snippets with current upstream documentation.

Confidence Score: 4/5

The stale changelog link should be corrected before merging so the schema split does not break an existing public documentation path.

The generated pages, navigation, metadata, and internal links are consistent, but the moved RefInputProperty anchor leaves the existing changelog URL pointing to a page that no longer contains its target.

Files Needing Attention: scripts/sync-schema-reference.mjs and changelog.mdx

Important Files Changed

Filename Overview
scripts/sync-schema-reference.mjs Adds the Inputs grouping and metadata correctly, but moving the anchors leaves an existing hand-authored changelog link stale.
module-definitions/definition-schema/input-types.mdx Adds a fully configured public page for the generated Input types reference.
snippets/schema-reference/module/input-types.mdx Contains the relocated input-property definitions and valid generated cross-page links, while confirming that RefInputProperty moved from its previous URL.
docs.json Adds the new Input types page to the Definition schema navigation in the expected position.
snippets/schema-reference/pipeline.mdx Refreshes generated pipeline reference content, including current concurrency semantics.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Source[Upstream module schema] --> Sync[sync-schema-reference.mjs]
  Sync --> Inputs[Inputs page]
  Sync --> Types[Input types page]
  Inputs --> Helpers[Validation, values, conditions, references]
  Types --> Properties["*InputProperty definitions"]
  Sync --> Navigation[docs.json and module index]
Loading
Prompt To Fix All With AI
### Issue 1
scripts/sync-schema-reference.mjs:43
**Moved anchor breaks link**

When readers follow the existing changelog link to `/definition-schema/inputs#refinputproperty`, this grouping has moved `RefInputProperty` exclusively to the new `input-types` page, causing the link to open a page without its referenced section. Update the hand-authored link or preserve the old anchor when splitting the page.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "Split the oversized module Inputs sectio..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Context used:

Co-Authored-By: brandon <brandon@flightcontrol.dev>
@mintlify

mintlify Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Ravion 🟢 Ready View Preview Aug 26, 2026, 9:38 PM

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@flybayer
flybayer merged commit d06a498 into main Aug 26, 2026
7 checks passed
],
Inputs: [
{title: "Inputs"},
{title: "Input types", match: /InputProperty$/},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Moved anchor breaks link

When readers follow the existing changelog link to /definition-schema/inputs#refinputproperty, this grouping has moved RefInputProperty exclusively to the new input-types page, causing the link to open a page without its referenced section. Update the hand-authored link or preserve the old anchor when splitting the page.

Knowledge Base Used: Reference generation and validation

Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/sync-schema-reference.mjs
Line: 43

Comment:
**Moved anchor breaks link**

When readers follow the existing changelog link to `/definition-schema/inputs#refinputproperty`, this grouping has moved `RefInputProperty` exclusively to the new `input-types` page, causing the link to open a page without its referenced section. Update the hand-authored link or preserve the old anchor when splitting the page.

**Knowledge Base Used:** [Reference generation and validation](https://app.greptile.com/flightcontrol/-/custom-context/knowledge-base/ravionhq/docs/-/docs/reference-generation-and-validation.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant