Split the oversized module Inputs section into its own input-types page - #69
Merged
Merged
Conversation
Co-Authored-By: brandon <brandon@flightcontrol.dev>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
flybayer
approved these changes
Aug 26, 2026
| ], | ||
| Inputs: [ | ||
| {title: "Inputs"}, | ||
| {title: "Input types", match: /InputProperty$/}, |
There was a problem hiding this comment.
When readers follow the existing changelog link to /definition-schema/inputs#refinputproperty, this grouping has moved RefInputProperty exclusively to the new input-types page, causing the link to open a page without its referenced section. Update the hand-authored link or preserve the old anchor when splitting the page.
Knowledge Base Used: Reference generation and validation
Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/sync-schema-reference.mjs
Line: 43
Comment:
**Moved anchor breaks link**
When readers follow the existing changelog link to `/definition-schema/inputs#refinputproperty`, this grouping has moved `RefInputProperty` exclusively to the new `input-types` page, causing the link to open a page without its referenced section. Update the hand-authored link or preserve the old anchor when splitting the page.
**Knowledge Base Used:** [Reference generation and validation](https://app.greptile.com/flightcontrol/-/custom-context/knowledge-base/ravionhq/docs/-/docs/reference-generation-and-validation.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly
Sync schema reference docsjob in flightcontrol has failed every run since Aug 15, so nothing generated from TypeSpec has reached these docs for ~3 weeks (most visibly,cancel-intermediateis missing from the publishedConcurrencyConfigreference even though it shipped in flightcontrol#6907). The job dies inscripts/sync-schema-reference.mjs:The module
Inputssection crossedmaxFieldsPerPage(220) by exactly one field, andsplitSectionthrows when an oversized section has nosectionGroupsentry. That throw aborts the whole script, so every page — including the unrelated pipeline reference — stops syncing.Grouping follows the existing
Deployprecedent (catch-all group first, so the section intro stays on the lead page):That keeps the existing
inputsslug (and itspageMetadata/OG image) intact and adds one newinput-typespage, withpageMetadatafor it and a narrowedinputsdescription now that the type reference moved off that page.The generated content in this PR is the full ~3 weeks of catch-up, regenerated from flightcontrol
mainat 0d2a8f2a9f (i.e. after the #7044 revert, so it does not contain the reverted build-step concurrency default). Largest visible change iscancel-intermediateand the expandedqueue_sizesemantics landing in the pipeline and module stack references.Testing
node scripts/sync-schema-reference.mjs+node scripts/sync-og-images.mjsrun clean; resulting pages are 197 and 24 fields, both under the 220 budget, and no other page moved past it.pnpm validatepasses.Link to Devin session: https://app.devin.ai/sessions/473f180911ca4629901d5d61fa043fd6
Requested by: @flybayer
Greptile Summary
The PR splits the oversized module Inputs schema reference into separate Inputs and Input types pages, then refreshes generated schema content accumulated during the failed synchronization period.
*InputPropertydefinitions and updates generated cross-page references.Confidence Score: 4/5
The stale changelog link should be corrected before merging so the schema split does not break an existing public documentation path.
The generated pages, navigation, metadata, and internal links are consistent, but the moved
RefInputPropertyanchor leaves the existing changelog URL pointing to a page that no longer contains its target.Files Needing Attention: scripts/sync-schema-reference.mjs and changelog.mdx
Important Files Changed
RefInputPropertymoved from its previous URL.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Source[Upstream module schema] --> Sync[sync-schema-reference.mjs] Sync --> Inputs[Inputs page] Sync --> Types[Input types page] Inputs --> Helpers[Validation, values, conditions, references] Types --> Properties["*InputProperty definitions"] Sync --> Navigation[docs.json and module index]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Split the oversized module Inputs sectio..." | Re-trigger Greptile
Context used: