Changes to bring rekmod in line with current behaviour in lekmod v34.15#360
Conversation
| "uniques": ["Comment [All Great Prophets generated by Lithuania become the Krivis, which can create the Sacred Grove]"], | ||
| "uniques": [ | ||
| "Comment [All Great Prophets generated by Lithuania become the Krivis, which can create the Sacred Grove]", | ||
| "Gain [100] [Faith] <(modified by game speed)> <upon founding a Pantheon>" |
There was a problem hiding this comment.
I don't think this is a thing. Is this supposed to replace the whole thing of the first prophet being cheaper? If so, this should be done with the [-50]% Faith cost of generating Great Prophet equivalents unique and a fake building, not like this
There was a problem hiding this comment.
Yupp, I'm very inexperienced at modding unciv and this was the first way that came to mind.
|
As implemented, the fake building doesn't do what you think it would do. To work as intended, you'd want the unique for Lithuania to read as |
That would indeed be more pretty. Tbf I think my solution is technically equivalent. Edit: Right, I did have a problem... |
|
Currently the prophet gets spawned, then the building gets built, and then the faith is only removed after the building takes effect. 
|
|
Starting with the next version, not anymore |
| "[+1 Production, +1 Food] from [Horses] tiles [in this city]", | ||
| "[+1 Production, +1 Food] from [Sheep] tiles [in this city]" | ||
| "[+1 Production, +1 Food] from [Sheep] tiles [in this city]", | ||
| "[+1 Production] from [Maize] tiles [in this city]" |
There was a problem hiding this comment.
Sorry for the delay. Been wanting to double check this, but have been busy with some other projects and work
I'm going to suggest the weird thing and say that the maize benefits to this and Poland's unique stable shouldn't be here unless something akin to #254 is merged. As is, I'm not entirely sure this benefit is intentional or is "stables benefit this resource, maybe it should benefit maize too
My personal opinion is I'm still not fully sure I buy the argument that Lekmod gives for splitting maize and wheat. Or rather, I feel like the design itself is kinda flawed and Lekmod should actually decide what it wants to do instead of splitting it and calling it a day without changing the benefit from stables from food to production
There was a problem hiding this comment.
I see, I was obviously unaware that this had been discussed before, sorry for not checking more thoroughly before changing.
|
|
|
Ok, looks good enough to me. Merging |
2 participants
This may be a bit suboptimal since there are very many changes here. I expect some of the fixed discrepancies were on purpose, so I'd appreciate it if someone could take a closer look at the changes.
I've attached a .txt with some of the intended changes. Items labeled Unmoddable have not been implemented. Most items labeled Mistakes have been implemented. The .txt is pretty messy, and if it would help I can definitely clean it up a bit!
rekmod discrepancies.txt