vclog: Report when gpu_mem is too low for logs - #215
Merged
Merged
Conversation
With gpu_mem=16 on Pi 0-4 the cut-down firmware provides no log buffer, so /proc/device-tree/chosen/log is absent and vclog failed with an unhelpful "Could not determine logs location" error. When the logs can't be found, query the VC memory size via the mailbox and, if it is 16MB or less, report that gpu_mem must be increased. Also make die() accept printf-style arguments.
Contributor
Author
|
See #158 |
pelwell
approved these changes
Oct 2, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With gpu_mem=16 on Pi 0-4 the cut-down firmware provides no log buffer, so /proc/device-tree/chosen/log is absent and vclog failed with an unhelpful "Could not determine logs location" error.
When the logs can't be found, query the VC memory size via the mailbox and, if it is 16MB or less, report that gpu_mem must be increased.
Also make die() accept printf-style arguments.