Skip to content

[CI] Use the default cpu8 node - #243

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
chyunsu3:use_cpu8_node
Oct 7, 2026
Merged

rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
chyunsu3:use_cpu8_node

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Closes #22

The default cpu8 node should be sufficient for this library.

@chyunsu3
chyunsu3 requested a review from a team as a code owner October 6, 2026 00:06
@chyunsu3
chyunsu3 requested a review from msarahan October 6, 2026 00:06
@chyunsu3 chyunsu3 added non-breaking Introduces a non-breaking change ci improvement Improves an existing functionality labels Oct 6, 2026
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: rapidsai/nvforest/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 7730212a-958a-4068-9199-0be26b1c0fc3
📥 Commits

Reviewing files that changed from the base of the PR and between 949bf82 and 5b7e410.

📒 Files selected for processing (2)
  • .github/workflows/build.yaml
  • .github/workflows/pr.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated several automated build jobs to use 8-core runners instead of 16-core runners.

Walkthrough

Five CI jobs in the build and pull request workflows now request cpu8 nodes instead of cpu16 nodes.

Changes

CI runner updates

Layer / File(s) Summary
Set CI build jobs to cpu8
.github/workflows/build.yaml, .github/workflows/pr.yaml
The cpp-build and wheel-build-libnvforest jobs in build.yaml, plus the conditional CPU C++ build, conda C++ build, and libnvforest wheel build in pr.yaml, now request cpu8 nodes instead of cpu16 nodes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5b7e4

No merge-blocking issue is established. The affected jobs’ performance on cpu8 has not been verified in the supplied evidence.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue #22 asks to test the default cpu8 node in build jobs. The change summary reports that the relevant C++ and libnvforest wheel build jobs in .github/workflows/build.yaml and `.github/workflows/p…
Out of Scope Changes check ✅ Passed The reported changes only switch build-job node sizes from cpu16 to cpu8. This directly supports issue #22. The whole-PR diff inspection failed because repository objects were unavailable, so this…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Title check ✅ Passed The title clearly summarizes the main change: CI jobs will use the default cpu8 node.
Description check ✅ Passed The description explains that cpu8 should be sufficient for the library and references the linked issue.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chyunsu3 chyunsu3 self-assigned this Oct 6, 2026
@chyunsu3

chyunsu3 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit a08f3dc into rapidsai:main Oct 7, 2026
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Test whether we can use the default nodes in build jobs

2 participants