Provenance: downgrade vault_graph/related/summary returns to primed surfaces - #110
Merged
Merged
Conversation
…ces, not uses A return is surfacing, not use (issue #103's model). get_neighborhood, find_related, and vault_summary still wrote tier='used' source='explicit' on mere returns, polluting the strong signal. Downgrade all three to tier='primed' with distinct provenance sources (graph/related/summary), and — mirroring vault_context — search-log the surfacing when feedback_enabled so a later read-after-surface infers 'used'/'inferred' via capture_read. vault_record_usage stays the explicit override. Part of #109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #109.
What
get_neighborhood(vault_graph),find_related(vault_related), andvault_summaryrecordedtier='used' source='explicit'on mere returns — the_record_note_usagedefaults. A return is a primed surface, not a use (#103's model).How
tier='primed'with distinct provenance sources:'graph','related','summary'(free-text column, no schema change;feedback_statsonly splitsusedby source).vault_context(Two-tier activation signal: primed (auto-RAG injection) vs used (deliberate record_usage) #95): whenfeedback_enabled, the surfacing is search-logged so a later read-after-surface infers the strong'used'/'inferred'signal viacapture_read. Without this, the strong signal was unobservable for these tools.vault_record_usageremains the explicit override for consumption the server cannot observe.schema.pyand_record_note_usage's docstring.Gate
ruff clean; 778 tests pass (769 + 9 new in
tests/test_surface_provenance.py: primed/provenance rows per tool, feedback-gated search-logging, no-results guard, and the acceptance check that none of the three surfaces writestier='used').