fix(compress): raise maxSummaryLengthHard default to 3000, fix reject feedback#43
Merged
ranxianglei merged 1 commit intoJun 30, 2026
Conversation
… feedback Reported in #42: the 800-char hard ceiling caused legitimate compressions to fail for real-world content (summaries routinely run 800-3000 chars). The ceiling is a safety net against pathological bloat, not a practical limiter, so 800 was miscalibrated. - config: maxSummaryLengthHard default 800 -> 3000 (soft target stays 200) - compress message/range: the reject message no longer tells the model to 'aim for <=200' (the soft target) at failure time — that was misleading. It now guides the model to trim under the actual ceiling and keep only essential detail. Tuning will be revisited with the upcoming compression-bundle feature; for now the search_context tool makes over-long summaries wasteful, so the soft target stays low. typecheck clean, 496 tests pass.
Owner
Author
|
link #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42 (prihuda's report:
maxSummaryLengthHard=800caused legitimate compressions to always fail).maxSummaryLengthHarddefault 800 → 3000. The 800 ceiling was miscalibrated — real summaries routinely run 800–3000 chars, so the safety net was catching normal compression instead of pathological bloat. The soft target (maxSummaryLength) stays at 200 to keep summaries concise (now thatsearch_contextcan retrieve compressed detail, over-long summaries are wasteful).Verification
tsc --noEmit: cleannode:20full suite: 496 pass / 0 failNotes
Tuning will be revisited once the compression-bundle feature lands; for now this unblocks users hitting the default.