Development#19
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/ranuru/schema-lab/sessions/0610e907-62a8-4f6e-af9d-51acd386714f Co-authored-by: ranuru <126164337+ranuru@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ranuru/schema-lab/sessions/0610e907-62a8-4f6e-af9d-51acd386714f Co-authored-by: ranuru <126164337+ranuru@users.noreply.github.com>
Add client-side timeout and safe comparison for Python challenge runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how timeouts are handled when running user code in Python challenges and introduces a utility function to centralize Python code execution logic. The changes improve maintainability and consistency for handling timeouts and errors.
Timeout and error handling improvements:
RUN_TIMEOUT_MSandRUN_TIMEOUT_MESSAGEfor consistent timeout configuration and messaging across the file (frontend/src/pages/ChallengePage.jsx).runWorkerfunction inChallengePage.jsx).Python execution refactor:
runPythonasync function that wraps the/runner/runAPI call with timeout and error handling usingAbortController, ensuring Python code execution is consistent with JavaScript execution (ChallengePage.jsx).runPythonfunction, removing duplicated fetch and error handling logic from the component (ChallengePage.jsx).