Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/jarl-react/src/__tests__/hooks.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { describe, it, expect, beforeEach } from "vitest";
import { describe, it, expect, beforeEach, vi } from "vitest";
import { render, screen, fireEvent } from "@testing-library/react";
import { rootAtom } from "jarl-atoms";
import { useRoute, useNavigate, useIsActive, useHref, useLink } from "../hooks";
Expand Down Expand Up @@ -51,6 +51,21 @@ describe("useNavigate", () => {
expect(screen.getByTestId("match")).toHaveTextContent("true");
expect(window.location.pathname).toBe("/about");
});

it("forwards { replace: true } as a replace navigation", () => {
goTo("/");
const pushSpy = vi.spyOn(window.history, "pushState");
const replaceSpy = vi.spyOn(window.history, "replaceState");
const Probe = () => {
const navigate = useNavigate(aboutAtom);
return <button onClick={() => navigate({}, { replace: true })}>Go</button>;
};
render(<Probe />);
fireEvent.click(screen.getByText("Go"));
expect(replaceSpy).toHaveBeenCalled();
expect(pushSpy).not.toHaveBeenCalled();
expect(window.location.pathname).toBe("/about");
});
});

describe("useIsActive", () => {
Expand Down
7 changes: 4 additions & 3 deletions packages/jarl-react/src/hooks.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useCallback, useMemo } from "react";
import { useAtom, useAtomValue, useSetAtom } from "jotai";
import { DefaultParams, RouteAtom } from "jarl-atoms";
import { DefaultParams, NavOptions, RouteAtom } from "jarl-atoms";
import { isActive } from "./isActive";

// Re-export jotai's own primitive hooks. Per jotai convention (see
Expand All @@ -21,11 +21,12 @@ export function useRoute<T extends DefaultParams>(routeAtom: RouteAtom<T>) {

/**
* Returns a stable `navigate` function bound to one route atom. Calling it with param values
* pushes a new location.
* pushes a new location; pass `{ replace: true }` as a second argument for a replace navigation,
* mirroring the route atom's own setter (`set(routeAtom, values, { replace: true })`).
*/
export function useNavigate<T extends DefaultParams>(routeAtom: RouteAtom<T>) {
const setRoute = useSetAtom(routeAtom);
return useCallback((to: T) => setRoute(to), [setRoute]);
return useCallback((to: T, options?: NavOptions) => setRoute(to, options), [setRoute]);
}

/**
Expand Down
Loading