Skip to content

Return true after queueing a guest syscall override #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sinan-Karakaya wants to merge 1 commit into from
Closed

Return true after queueing a guest syscall override #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ps2xRuntime/src/lib/Kernel/Syscalls/System.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,11 @@ namespace ps2_syscalls
parent.r[2] = completed.r[2];
};
scheduler.invokeCurrent(std::move(invocation));
// The invocation is queued and the caller must not fall through to the

@ran-j ran-j Aug 18, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think I remove the return when I has moving the code, can you remove this comments

@ran-j ran-j Aug 18, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waitttt. I remenber now.

look at invokeCurrent its a [[noreturn]] so your return true; is unreachable

// built-in handler. Falling off the end of a non-void function here was
// undefined behaviour: whatever happened to be in the return register
// decided whether the built-in ran as well as the guest's override.
return true;
}

static bool tryResolveGuestSyscallMirrorAddr(uint32_t syscallIndex, uint32_t &guestAddr)
Expand Down