Add files via upload#4674
Conversation
|
Thank you for the submission. There are already two mods that implement the genie effect: The second mod is actively developed. If it has issues or is missing features, it's preferable to work with the mod author on improving it rather than having yet another genie animation mod, which will fragment the mod catalog and confuse users. |
|
@m417z hi, iam sorry but i have been working on mine for a while. https://www.reddit.com/r/Windhawk/comments/1u8hhke/macos_genie_effect_wip/ sorry for bad grammer |
|
@m417z please reply |
|
My priority for Windhawk is to provide the best experience for users. I hope that you can agree that it's a goal worth perusing. For the genie animation feature, having dozens of different genie animation mods will be counterproductive for users. It's great that you managed to create another high-quality implementation, and you can use that experience to help the community by improving the existing mod, MacOS Minimize Animation, by @Abdullah-Masood-05. @Abdullah-Masood-05, will you be open to collaboration with @Potassiumuncher on improving the mod? Is submitting a pull request in your repo the best way to contribute? Let me know what you both think about a joint effort to create a single high quality genie animation mod. |
|
@Potassiumuncher I looked closely at your mod and your demo, and credit where it's due — your genie is genuinely well done. The Direct2D mesh warp gives a more authentic macOS curve than mine: the window content stays visible and flows along the funnel instead of narrowing and fading, which is exactly the look people want. Your UI-Automation taskbar-button lookup (matching the window to the actual taskbar element) is also more precise than my cursor-based heuristic, and the auto-hide "unhide until the animation finishes" handling is something users have literally been requesting on my issues. Those three are real advances. There are also areas where the current published mod is further along, and I'd want to make sure a merge doesn't regress them:
Given all that, I'm very open to collaborating. The cleanest approach is probably your rendering/curve and your taskbar + auto-hide features layered onto the existing hook and lifecycle structure, so we get the better animation without losing the app coverage and stability. PRs to my repo (https://github.com/Abdullah-Masood-05/windhawk-mods) work great. If your animation goes in, I'd absolutely want you credited as a co-author on the mod. @m417z happy to move forward with this as a single mod with Potassiumuncher contributing. What's the preferred way to credit a co-author in the mod metadata — a separate contributors field, or something else? Want to make sure it's done in the format you'd like. |
Each mod in Windhawk has a single author - the person responsible for the mod and for updating it. Contributors, co-authors, or other credits and references can be specified in the readme. |
|
@m417z @Abdullah-Masood-05 i would be happy with a collaboration as iam busy with school so i wont be able to maintain it. I will send over the newest file with the 'unhide taskbar' and you can help me with any issues there are. the 'unhide taskbar' took a while to figure out so there may be some bugs I did not find. I can hand over the mod to you but you have to be able to maintain the mod, just make sure you credit me. |
|
heres a preview of the taskbar unhide |
|
@m417z thanks, that's clear, single author, contributors in the readme. That works perfectly. @Potassiumuncher really appreciate you being open to this, and no worries about school, I'm happy to maintain it, and you'll be credited in the readme as the contributor of the Direct2D genie rendering and the taskbar auto-hide handling. Go ahead and send over the newest file. Fair warning on timing: I'm pretty tight this week too (same as I mentioned on #4670), so I'll do the integration properly next week rather than rushing it in not putting it off, just want to give it the time it needs. On how I'll approach the merge, so you know what to expect: I'll bring your rendering and the taskbar/auto-hide features onto the current mod's hook and lifecycle structure (the extra entry-point hooks for custom-titlebar/UWP apps, the unload-safety draining, the cloak-based restore) rather than swapping files wholesale that way we keep your better animation and taskbar handling without losing the app coverage and stability. I'll work through the known bits (the translucent-window greying, and any edge cases in the taskbar-unhide you mentioned) as I integrate. The auto-hide preview looks great, by the way. I'll follow up here and on the repo as it comes together. |
3 participants
Changelog
If this pull request updates an existing mod, describe the changes below:
Mod authorship
If this pull request introduces a new mod, please complete the section below.
This mod was created by:
Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.