UPDATE: added new mappings and redirects for the system tray#4392
Conversation
UPDATE: added new mappings and redirects for the system tray
|
Doеs not work in tray context menu for me, opens Settings as before. |
If possible, show me the settings of the mod since I've added this as a setting so that I can troubleshoot this further |
With this option enabled, also opens Settings.
|
Thank you for sharing this image. I've tested it on Windows 10 21H2 and it works but since I can't test it on Windows 11 I assume that the issue is ExplorerPatcher since the Windows 10 taskbar from ExplorerPatcher could work differently from the original Windows 10 one |
|
I do not use Explorer Patcher. |
Thanks for the clarification. |
|
Sorry, this is my bad. Your redirects now work for me. |
|
@m417z works for me now. |
|
I think, tray network context menu should aopenb this: |
- Changed a mapping - Removed less stable parts
Thank you for the suggestion. I've updated the mapping to make it more similar to Windows 7's |
|
@babamohammed2022 can you fix here the redirect as well, the same way you did in the network mod? |
I will work on a fix for this mod soon, right now I'm focusing on the network flyout one to avoid disorganization but thanks for the reminder |
I've fixed them and they work. |
|
Tray redirect does not work, opens settings for me. |
This comment was marked as outdated.
This comment was marked as outdated.
OK, I will try to fix it |
|
Both open Settings. |
Hi, if possible let me know if it works now. I've replaced the hardcoded IDs with one that involves multiple approaches based on the Windows version and the presence of ExplorerPatcher to deal with the DLL. |
|
How is this related to the IDs if it sometimes works, sometimes not? |
|
Now, power settings redirects to CP, while sound settings open the Settings app. Here is the log: There are no log messages when clicking the menu item. |
It looks like you have RedirectSystemTray=0 therefore it means that the option to redirect the system tray is disabled (I will make it enabled by default once I make it more stable). Please, enable it and let me know what happens. |
I changed the approach because before I used fixed menu IDs, now I detect menus by checking which DLL creates them (SndVolSSO.dll for audio, pnidui.dll for network) or by reading the menu text |
|
When enabled, its the same: 19:35:37.306 9108 explorer.exe [WH] [local@settings-to-control-panel] [1404:Wh_ModInit]: Redirect Settings to Control Panel v10.0.5 |
|
The menu text is different in all languages, plus it will bring false positives if some other software has these strings. |
Thank you for sharing the logs, I will analyze them. For now it looks like it fails to intercept the context menus despite loading the DLLs |
|
@Anixx would you like to test it before it's merged? |
|
Troubleshooting in the Control Panel does not work. On the first click nothing happens, on the second, Settings open. |
Thank you for reporting the issue. Does it work now? |
|
"Open Devices and Printers" in the tray |
OK, let me know if this issue has been addressed properly |
|
No. It still opens Settings. |
Alright, I'll check again and try to implement a more robust solution |
I've tested on Windows 11 24H2 with ExplorerPatcher and Device & Printers tray redirect seems to work correctly Audio and Network seem to work too. I've added a note in the README limitations about this not working in all configurations for transparency, despite it working on my setup. Let me know if there are other issues to address |
|
The last version opens Settings instead of Files and Printers. |
OK, what about the redirect of the USB in the system tray? does it work now? |
|
No, the system tray item "Devices and Printers" opens Setting |
Have you enabled the system tray redirect in the settings? Just to confirm |
|
Yes, also in the last version the network settings redirect in tray also does not work. The sound redirect works. 
|
Fair, I'll try to fix both issues |
…vice & Printers on Windows 11
|
I've marked the system tray redirect as experimental and documented the Device & Printers limitation in the README.
|
|
Confirming, all redirects work except Files and Printers. |
|
@m417z while one feature is not implemented, the current version is no doubt, an improvement. |
|
Tray redirect does not work again, neither for sound, nor for network. It is enabled in Settings. Probably, it stops working when the Explorer restarts. |
|
Yep, the redirect stops working when the Explorer is restarted, to make it to work again I have to restart the mod. On reboot or relogon it stops working again. |
Could you send the logs for a more accurate analysis? I've just tried and I don't seem to have this issue |
|
The log is empty when the redirect does not work. For instance, I just restarted explorer, the sound redirect works, with log, but network redirect does not and shows no log. |
I've tried to fix this issue. Please try it in this PR: #4727 and tell me if it works |
3 participants
UPDATE: added new mappings and redirects for the system tray
Changelog
If this pull request updates an existing mod, describe the changes below:
Mod authorship
If this pull request introduces a new mod, please complete the section below.
This mod was created by:
Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.