Fix pi-screen dead session handling - #93
Open
ralphschuler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
pi-screenso dead GNU screen sockets are not treated as resumable pi sessions.Changes
screen -lsstatus and classifyAttached,Detached, andDeadexplicitly.pi-screensession listings to live sessions only (Attached/Detached).screen -ragainst the dead socket.pi-screenhelp/docs to describe live-session behavior.Validation
node --test tests/unit/pi-screen.test.mjsnpm run checkRisks/Rollback
Low risk: the change only filters dead/unknown screen entries from
pi-screenmanagement paths. Roll back by reverting this commit if live sessions are unexpectedly hidden.Related Issues
None.
Conversation Context
User reported that
pi-screentries to reopen a dead repo session and should not rely on stale/cached screen state; each invocation should list current screens and ignore vanished sessions.