feat: make name set iterable - #19
Closed
ralflorent wants to merge 1 commit into
Closed
ralflorent wants to merge 1 commit into
ralflorent wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the name set iterable (i.e., for-of statements).
This is similar to
partswith the exception that all name components are returned asNameclasses (instead of their natural form - e.g.,FirstNameorLastName) to maintain certain homogeneity and consistency across each name piece.This PR also includes changes to support flexible types instead of being forced to import enums (
Separator,NameOrder, etc.) to customize the behavior of the name components viaConfig. For example, working with names ordered by family name should be as easy as doing this: