Repository navigation
Composer history: History n/N on a free composer rule while browsing (#389) - #441
Closed
raiseCatError wants to merge 2 commits into
Closed
raiseCatError wants to merge 2 commits into
raiseCatError wants to merge 2 commits into
Conversation
…sing While Up/Down browse an unchanged recalled entry, its position sits on the bottom composer rule (or the top one when that is the free one), in the subtle chrome role. It yields to Keep Awake and a header prompt, never adds a row, and is not shown when no rule has room.
This was referenced Oct 18, 2026
Open
Merged
…th never wraps the frame The one-line prompt shows the directory NMSh started in. From a checkout whose path is long and not abbreviated (seen at .../notMyShell/v022-release), the recalled command wrapped onto a second row at 80 columns and the test read only the first. The product is unchanged; the frames now start in /.
raiseCatError
added a commit
that referenced
this pull request
Oct 19, 2026
…(feature/v022-history-position b57bb68)
Owner
Author
|
Release follow-up, |
Owner
Author
|
Its commits (head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
While Up/Down browse an unchanged recalled command (#438's browsing state), the composer's bottom rule shows where you are:
History 1/Nis the most recent command. N is how many distinct commands Up can reach in this browse (the bounded snapshot Composer history: a recalled command is one step, however many lines it has (#389) #438 takes, at most 1000).renderComposerEdge, the shared edge renderer Keep Awake uses, so the rule keeps its own colours and Chroma, and transition light stays off the label.Verification
New:
tests/historyPosition.test.ts, through realTerminalAppframes, in the default header layout, one-line and two-line composer layouts. It checks:Three of the four tests fail on Composer history: a recalled command is one step, however many lines it has (#389) #438's head; the narrow-window one guards absence and passes there too.
Suites: composer history (idle and running), composer layout and dividers, Keep Awake (presentation and foreground), screen plan, Flow composer: 90 pass, 2 live tests timed out at load 37 (from a parallel full run) while waiting for the shell's first prompt; recorded below when rerun at normal load.
Full canonical
npm run verify: pending. CI runs on this PR.Physical QA (not done)
Ghostty and Terminal.app; zsh, Bash and Fish; with a few commands in history:
History 1/N. Further Up and Down change the number, and Down past the newest removes it./keep-awake display: Keep Awake keeps its place, and the label is on the other rule or absent.Refs #389