Pass configured effort through to split-plan generation - #37
Open
rafaeelricco wants to merge 1 commit into
Open
Conversation
- Remove `withMinEffort` from `src/domain/llm/effort.ts`. - Call `generateContent` with the incoming `config` in `generateSplitPlan`. - Delete `withMinEffort` unit tests and assert configured effort reaches the provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Split-plan ignored user effort (always low/MINIMAL) so high-effort picks never reached the provider.
What's New
Split Plan Effort
generateSplitPlannow passes the incomingProviderConfigtogenerateContentinstead of wrapping it withwithMinEffort.withMinEffortis removed fromsrc/domain/llm/effort.tsso split-plan uses the same selected effort as other LLM calls.Split Plan Effort Flow
flowchart TB splitPlan["generateSplitPlan"] --> config["incoming ProviderConfig"] config --> generate["generateContent"] generate --> provider["Provider with config.effort"]Changed Files
src/domain/llm/effort.ts— Modified — RemovewithMinEffortand its exports/imports.src/domain/llm/router.ts— Modified —generateSplitPlancallsgenerateContent(config, ...).test/domain/llm/effort.test.ts— Deleted — Tests forwithMinEffort.test/domain/llm/router.test.ts— Modified — Assert configured effort (high) reaches the provider.Testing & Feedback
Review
generateSplitPlaninsrc/domain/llm/router.ts: it must passconfigthrough unchanged. Confirm the router test expectsJust("high")on the provider call, and thatwithMinEffortis gone fromeffort.tsand its test file.If you find any bugs or have recommendations for improvements, please open an issue and assign it to me.