Skip to content

Pass configured effort through to split-plan generation - #37

Open
rafaeelricco wants to merge 1 commit into
mainfrom
rafaeelricco/drop-split-min-effort
Open

Pass configured effort through to split-plan generation#37
rafaeelricco wants to merge 1 commit into
mainfrom
rafaeelricco/drop-split-min-effort

Conversation

@rafaeelricco

Copy link
Copy Markdown
Owner

Motivation

Split-plan ignored user effort (always low/MINIMAL) so high-effort picks never reached the provider.

What's New

Split Plan Effort

  • generateSplitPlan now passes the incoming ProviderConfig to generateContent instead of wrapping it with withMinEffort.
  • withMinEffort is removed from src/domain/llm/effort.ts so split-plan uses the same selected effort as other LLM calls.

Split Plan Effort Flow

flowchart TB
    splitPlan["generateSplitPlan"] --> config["incoming ProviderConfig"]
    config --> generate["generateContent"]
    generate --> provider["Provider with config.effort"]
Loading

Changed Files

  • src/domain/llm/effort.ts — Modified — Remove withMinEffort and its exports/imports.
  • src/domain/llm/router.ts — Modified — generateSplitPlan calls generateContent(config, ...).
  • test/domain/llm/effort.test.ts — Deleted — Tests for withMinEffort.
  • test/domain/llm/router.test.ts — Modified — Assert configured effort (high) reaches the provider.

Testing & Feedback

Review generateSplitPlan in src/domain/llm/router.ts: it must pass config through unchanged. Confirm the router test expects Just("high") on the provider call, and that withMinEffort is gone from effort.ts and its test file.

If you find any bugs or have recommendations for improvements, please open an issue and assign it to me.

- Remove `withMinEffort` from `src/domain/llm/effort.ts`.
- Call `generateContent` with the incoming `config` in `generateSplitPlan`.
- Delete `withMinEffort` unit tests and assert configured effort reaches the provider.
@rafaeelricco rafaeelricco self-assigned this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant