docker: fail the image build when requirements.txt is not satisfied - #86
Closed
Rockdu wants to merge 1 commit into
Closed
docker: fail the image build when requirements.txt is not satisfied#86Rockdu wants to merge 1 commit into
Rockdu wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Closing: the actual need (docker PRs build their own image and test inside it) already exists via docker-paths/docker-build/resolve-ci-image; this extra build-time validation isn't worth the surface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docker/check_requirements.py+ a finalRUNin the Dockerfile: after all installs, verify everyrequirements.txtentry is present at a satisfying version (handles extras, git URLs, and platform markers), then smokeimport miles. A stomped or missing requirement now fails the build instead of shipping a brokenpr-N/latest.docker-pathsin pr-test.yml, push paths in docker-build.yml) also watch the checker script.Why
--no-deps(sglang, wheels) afterpip install -r requirements.txt, so a requirement can be silently downgraded or removed; nothing validated the final state. Whole-envpip checkis not usable as a gate — the--no-depsinstalls make it noisy by design (15+ pre-existing complaints in the current image).Validation
rockdu/miles_diffusion:latest: current requirements pass; a seeded version mismatch and a missing package both fail with exit 1 and a per-entry report.🤖 Generated with Claude Code