Skip to content

change the teaching languages to use opt-in / opt-out toolbar buttons instead of drracket:toolbar-buttons - #268

Open
rfindler wants to merge 1 commit into
racket:masterfrom
rfindler:avoid-drscheme-toolbar-buttons
Open

rfindler wants to merge 1 commit into
racket:masterfrom
rfindler:avoid-drscheme-toolbar-buttons

Conversation

@rfindler

@rfindler rfindler commented Oct 7, 2026

Copy link
Copy Markdown
Member

This is part of a larger change to avoid using drracket:toolbar-buttons. The power that offers is not needed here because the teaching languages already are using the drracket plugin API.

@jbclements @mikesperber I've tested this trying out the #lang-based teaching languages (which is all this affects) but I would love to get some sanity checking here or maybe a pointer to a test suite.

@rfindler
rfindler requested a review from jbclements October 7, 2026 19:47
@rfindler
rfindler force-pushed the avoid-drscheme-toolbar-buttons branch from 81ca785 to 229c190 Compare October 7, 2026 20:11
@rfindler

rfindler commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

@mikesperber we'll also want to change Deinprogramm as I'm hoping to disable the drscheme:toolbar-buttons functionality (ie DrRacket just won't call it). I'm still investigating but there doesn't seem to be a need for it at least in these cases.

@rfindler
rfindler force-pushed the avoid-drscheme-toolbar-buttons branch from 229c190 to 3c4da84 Compare October 15, 2026 20:57
instead of drracket:toolbar-buttons

the later is just a set of symbols that the language offers to drracket
and the former is an arbitrary callback (that gets run as a part of
drracket itself)
@rfindler
rfindler force-pushed the avoid-drscheme-toolbar-buttons branch from 3c4da84 to 23e2841 Compare October 15, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant