Repository navigation
Run a window manager under xvfb-run - #23
Merged
Merged
Conversation
samth
force-pushed
the
xvfb-window-manager
branch
2 times, most recently
from
October 8, 2026 17:46
7feed1b to
8b85db6
Compare
Tests listed in test-xvfb-paths ran on a bare Xvfb display, where no window ever gets the focus. Many GUI tests assume that a window manager focuses a newly shown frame, as metacity does on the shared display, so they failed or hung under xvfb-run. xvfb-run now runs the new with-wm.sh, which starts the window manager from fluxbox-path on the new display, waits a second for it to take over the screen, runs the test, and exits with the test's status. The shared display and with-wm.sh take the window manager's arguments from one definition. The xvfb tests now use fixture files in tests/xvfb instead of writing programs from strings, and a new test checks that a frame shown under xvfb-run gets the focus.
samth
force-pushed
the
xvfb-window-manager
branch
from
October 8, 2026 17:50
8b85db6 to
6539df4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests listed in test-xvfb-paths ran on a bare Xvfb display, where no
window ever gets the focus. Many GUI tests assume that a window
manager focuses a newly shown frame, as metacity does on the shared
display, so they failed or hung under xvfb-run.
xvfb-run now runs the new with-wm.sh, which starts the window manager
from fluxbox-path on the new display, waits a second for it to take
over the screen, runs the test, and exits with the test's status. The
shared display and with-wm.sh take the window manager's arguments
from one definition.
The xvfb tests now use fixture files in tests/xvfb instead of writing
programs from strings, and a new test checks that a frame shown under
xvfb-run gets the focus.