fix(ironic-runbooks): use a system scope token and fix the update script operations - #2258
Merged
Merged
Conversation
Mount the system-scoped infrasetup-system secret instead of baremetal-manage for the shell-operator clouds.yaml, granting the runbook controller system-readwrite scope.
Fixed up the ironic runhook update script to create or update the runbook depending on if it exists. Switch to using the UUID for the curl calls since that is required.
cardoe
changed the title
cardoe
marked this pull request as ready for review
August 28, 2026 18:30
cardoe
enabled auto-merge
August 28, 2026 18:31
nicholaskuechler
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manipulating public runbooks requires a system scope user so switch to that. The update_runbooks.sh script could get called if the runback didn't yet exists based on k8s state so handle it gracefully by creating or updating. Switch to using the UUID since that's required in the API calls.